Magebean Logo Magebean
← Back to Baseline

MB-0814

Partially automated Avoid direct request superglobals in module log calls

MB-C03 Secure Coding Practices Medium

Selected PHP and PHTML module source avoids direct request superglobal references in arguments to enumerated log-like methods.

Overview

Inspect the reported log-like call, receiver and arguments. Direct request superglobals can copy secrets or attacker-controlled content into logs; trace the actual logging behavior and retention.

Why it Matters

Request logging can retain credentials, tokens or personal data outside the intended request boundary.

Interpret the reported resource and collection scope before making changes. Unsupported source, unresolved symbols and bounded collection gaps cannot establish a clean result.

Verification Steps

Manual Verification

  1. Inspect the reported log-like call, receiver and arguments. Direct request superglobals can copy secrets or attacker-controlled content into logs; trace the actual logging behavior and retention.
  2. Inspect the reported file, declaration, package or evidence record in the same selected release. Keep source observations separate from effective runtime behavior.
  3. Apply the rule-specific remediation below, validate the affected behavior in staging, and rerun the same selection.

Command / Review Sample

php magebean.phar audit --path=/var/www/magento --profile=module-integrity --rules=MB-0814 --modules=Vendor_Module

Use the assessed Magento project and the appropriate application or read-only review account. Replace example hosts, paths and identifiers with the assessment scope; configuration and source fragments are illustrative.

Remediation / Fix Guidance

  1. Inspect each named call and argument at the reported file/line. Trace input origin, receiver identity, authorization and output use before deciding whether to replace the API or document an approved exception to this explicit coding policy.
  2. Test the affected behavior and its real trust boundary. Replacing an API or wrapping a call does not by itself validate input or remove an exploit path.
  3. Rerun MB-0814 against the same release, profile and relevant file/key/package scope; compare the new evidence and inspect any independent collection gaps.

Examples

Illustrative declaration/review examples, not recorded scan output. A pass example concerns only the stated predicate and supported collected scope.

Fail Example

$logger->info($_POST);

Pass Example

$logger->info("Request rejected");
// No direct request superglobal in this log argument.
// Separately review other inputs and sensitive data.

Scope and Evidence Limits

Rule revision: 1. Target modes: LOCAL.

Selected PHP and PHTML module source avoids direct request superglobal references in arguments to enumerated log-like methods.

Reuses the exact syntactic request logging policy. Receiver type, dataflow and actual delivery are outside scope.

Catalog coverage describes implementation capability, not a scan outcome. An incomplete manual review cannot establish that the criterion is satisfied.

References